-
-
Notifications
You must be signed in to change notification settings - Fork 130
Change it so the categories endpoint is consistent by removing slugify #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
technoph1le
merged 1 commit into
quicksnip-dev:main
from
ACR1209:fix/fix-categories-failing-to-load-for-framework
Jun 2, 2025
Merged
Change it so the categories endpoint is consistent by removing slugify #276
technoph1le
merged 1 commit into
quicksnip-dev:main
from
ACR1209:fix/fix-categories-failing-to-load-for-framework
Jun 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI checks are failing, but I think it's trying to call an nonexistent script cspell from the project root, or am I mistaken? 😟
@ACR1209
ACR1209
force-pushed
the
fix/fix-categories-failing-to-load-for-framework
branch
from
June 1, 2025 03:25
3d7fe5c to
4c3efea
Compare
@technoph1le
technoph1le
merged commit Jun 2, 2025
7c1e59f
into
quicksnip-dev:main
0 of 2 checks passed
Hi, there. Thanks for the fix. It's interesting why cspell threw an error. I will look into that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes the use of the
slugifyfunction from the categories endpoint when fetching the json data, as this is inconsistent with the rest of the endpoints, which do not do this step.Type of Change
Checklist
Related Issues
Closes #275
Additional Context
This was failing due to inconsistent rules regarding if the passed language is slugged or not. On snippets they're not slugged, thus simply removing this fixes the consistency problem.
Meaning, the current syntax to denote a sub-language (eg.
javascript--react) was getting slugged like it was it's own language (eg.javascript-react).