-
-
Notifications
You must be signed in to change notification settings - Fork 128
grid-container: allow the grid to shrink to fit all avalible space to prevent sidescroll. #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add myself to comply with quicksnip contribution guidelines
For some reason "edit and fork" didn't save my inital edit which did this on my fork, thanks github.
@tryoxiss
tryoxiss
requested review from
majvax and
Mathys-Gasnier
as code owners
March 12, 2025 19:32
Mathys-Gasnier
Mathys-Gasnier
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
On some browsers, this has no effect on very small sizes such as 250px, since there is another limiting factor which prevents further shrinkage (e.g., word length). However this does work if the size is increased or the other limiting factors are removed.
Description
This simply replaces
250px
withmin(250px, 100%)
. This makes it so that if not enough space is avalible, the grid will simply take up all avalible space instead of forcing horizontal scroll.Type of Change
Checklist
Related Issues
Closes #267
Additional Context
Screenshots (Optional)
(column width increased in demos for ease of demonstration)
Before:
image
After:
image
Click to view screenshots
EDIT: Update images so the viewport is exactly the same width