-
-
Notifications
You must be signed in to change notification settings - Fork 130
Added more utility functions for string manipulation in C++ #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you taking the string by reference ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a constant reference is a good thing. It will not copy the whole variable, but just create a reference. But in this case yes, instead of making a const reference here and then creating another copy to return the string. They can just pass by value and return that string after transforming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this snippet really require, when its just a single function in the STL?
Hey, we recently updated how snippets are stored, please update your PR to match the changes, you will be able to see how to add snippets in CONTRIBUTING.md.
For ref: #87
Hey, changes were requested on your PR, but we got no news for more than a week, Closing this as stale.
the functions include