-
-
Notifications
You must be signed in to change notification settings - Fork 130
feat: add responsive 404 error page with modern design and decorations #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @erison7596. I would like to know how this NotFound page is reached? Maybe you should include a fallback route in the AppRouter to the NotFound component. Also, try to fix the CSS to use the color variables so the colors match the theme and are compatible with light/dark mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for your contributions. I noticed some issues in your code that doesn't follow the style guide. Please make the necessary changes before we can proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recommend using our own declared fonts instead of new ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @psychlone77 suggested as well, using custom variables help match with both dark and light themes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use BEM naming convention for naming selectors. You can refer here for details: https://getbem.com/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the comment in english
Ok, I tweaked around here and there. Then, I thought who needs 404 page anyways? So, instead of directing the user to 404 NotFound page, I set up the redirects so that it goes to the main homepage back again. Here's the commit.
It seems to be the easiest and "quickest" solution that works without crashing. If you face any issues, let us know. :)
@erison7596 thanks once again for your contribution. Since you didn't respond for over 3 weeks, I'm closing this issue.
If you want to work on it in the future, make sure to follow our style guide and open a new PR next time. Cheers xD
Description
Type of Change
Checklist
Related Issues
Closes #
Additional Context
Screenshots (Optional)
Click to view screenshots