-
-
Notifications
You must be signed in to change notification settings - Fork 130
Enhance snippet display with scrollbar #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance snippet display with scrollbar #252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adjustments. I have made some reviews. Please review them before we can proceed.
src/styles/main.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I advise using the CSS custom property for colors as there are dark and light mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay. I have implement these changes in this commit.
Commit Id: 07e5551
src/styles/main.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about setting lower height like 90vh?
Also, setting min-height would ensure it doesn't get too small and squishy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's pretty great. I have done this changes in this commit.
Commit Id: 07e5551
Description
Type of Change
Checklist
Related Issues
Closes #251
Additional Context
Screenshots (Optional)
Click to view screenshots