-
-
Notifications
You must be signed in to change notification settings - Fork 130
Remove blinking arrow and add message for empty categories #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove blinking arrow and add message for empty categories #245
Conversation
...play message when no snippets are found
Hey, there. Thanks for fixing it. We will be able to merge the PR once we successfully implement the search feature on #159. Because it's a pretty big PR with a lot of changes.
Hey, there. Thanks for fixing it. We will be able to merge the PR once we successfully implement the search feature on #159. Because it's a pretty big PR with a lot of changes.
Okay, will be on the lookout in case of conflicts
Okay, will be on the lookout in case of conflicts
Search PR is successfully merged. Feel free to resolve the conflicts and we should be good to go.
Search PR is successfully merged. Feel free to resolve the conflicts and we should be good to go.
Done! Sorry for the delay, went on a mini vacation π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Description
Remove the blinking arrow that sometimes appeared when changing language and add a message when the category has no snippets.
Type of Change
Checklist
Related Issues
Closes #241
Additional Context
I simply don't render the spinner as the time it's present it makes the blinking happen either way and with
AnimatePresenceit looks good to me.Screenshots (Optional)
Click to view screenshots
image