-
-
Notifications
You must be signed in to change notification settings - Fork 129
Contribute human-date.md #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Contributing Human readable Date format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, Thanks for your contribution !π
However, your title doesn't match the name of the file, It should be Human Date or you can do the opposite and rename the file human-readable-date. See other snippets for reference.
Please read CONTRIBUTION.md carefully.
I think you should add a locale argument to format date to other country standard like fr-FR that default to en-US.
Changed to comply with the Contribution Rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this looks more like an example on how to use the js date formatter than a snippet...
Contributing Human readable Date format
Description
Type of Change
Checklist
Related Issues
Closes #
Additional Context
Screenshots (Optional)
Click to view screenshots