Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add some responsive breakpionts in CSS #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
technoph1le merged 1 commit into quicksnip-dev:main from kruimol:main
Dec 30, 2024
Merged

Add some responsive breakpionts in CSS #24

technoph1le merged 1 commit into quicksnip-dev:main from kruimol:main
Dec 30, 2024

Conversation

Copy link
Contributor

@kruimol kruimol commented Dec 30, 2024

To create a multi platform website you need breakpoints for varius platforms.
So I added Responsive design, with: phone, tablet and desktop

To create a multi platform website you need breakpoints for varius platforms.
so I added Responsive design, with: phone, tablet and desktop
Copy link

netlify bot commented Dec 30, 2024
edited
Loading

Deploy Preview for quicksnip ready!

Name Link
🔨 Latest commit 475d5c2
🔍 Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/67727e3a10a8ea00084bdcb5
😎 Deploy Preview https://deploy-preview-24--quicksnip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the Desktop extra large and bige really necessary ?

Copy link
Contributor Author

kruimol commented Dec 30, 2024

Are the Desktop extra large and bige really necessary ?

It may be necessary in some cases,
If you don't need the extra large and big ones, remove them, it's still a 'template'/snipid
In my case I have a 2.7K screen, so it may be useful.

Copy link
Collaborator

I think snippet should show the functionning of a feature, and for media queries i think just showing the user how it works (explaining that it only applies if screen size > an amount, etc) is the goal, more than giving the user a list of media queries without explaination

Copy link
Contributor Author

kruimol commented Dec 30, 2024

I think snippet should show the functionning of a feature, and for media queries i think just showing the user how it works (explaining that it only applies if screen size > an amount, etc) is the goal, more than giving the user a list of media queries without explaination

That's true,
but sometimes I don't know what the correct sizes/breakpoints are,
so I thought it would be helpful to include the ''standard' breakpoints.

Copy link
Collaborator

@kruimol, thank you for the contribution. 🙌

I like the idea of adding responsive design. Regarding the breakpoints, we can move them to SCSS maps to show in an organized way. Something like this:

// values needs to be updated here as well
$breakpoints: (
 sm: 30em,
 md: 50em,
 lg: 75em,
);

Add a mixin to access those breakpoints from maps with @media, and now you have a useful code snippet that people can just copy and use in their code.

// media query
@mixin mq($key) {
 $size: map-get($breakpoints, $key);
 @if ($size) {
 @media (width > $size) {
 @content;
 }
 } @else {
 @error '`#{$key}` does not exist in the $breakpoints';
 }
}

Let me know what you think.

Copy link
Collaborator

And, we still need breakpoints in CSS as well. Because some developers aren't familiar with SCSS yet. So, adding a code snippet for common breakpoints would help them a lot.

I think margin might be unnecessary, just mentioning very common 3-4 breakpoints might be enough to give an idea.

I'm open to listening your approach on this one as well.

Copy link
Contributor Author

kruimol commented Dec 30, 2024

And, we still need breakpoints in CSS as well. Because some developers aren't familiar with SCSS yet. So, adding a code snippet for common breakpoints would help them a lot.

I think margin might be unnecessary, just mentioning very common 3-4 breakpoints might be enough to give an idea.

I'm open to listening your approach on this one as well.

Yes that was my intention too, I'm not that familiar with scss myself.
That's why I thought I'd add the @media breakpoints.
The margins are just an example of how to use them.
Like in this example that the margin increases as the screen gets bigger.
And if possible, leave the big ones as they are, because some screens it can be more useful for those big ones.

@technoph1le technoph1le merged commit a4fd8a0 into quicksnip-dev:main Dec 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathys-Gasnier Mathys-Gasnier Mathys-Gasnier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /