Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[Snippets] New languages + python tkinter snippets #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legopitstop wants to merge 0 commits into quicksnip-dev:main from legopitstop:main

Conversation

Copy link
Contributor

@legopitstop legopitstop commented Jan 19, 2025 •
edited
Loading

Description

Added languages

Type of Change

  • ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots

Copy link
Contributor Author

I haven't tested if the new snippets are working as I get this error when running npm run dev after running npm install, but I did run npm run snippets:check which ran with no errors.

error when starting dev server:
TypeError: Cannot read properties of null (reading 'toString')
 at consolidateSnippets (file:///C:/Users/legopitstop/Documents/GitHub/Forks/quicksnip/vite.config.ts.timestamp-1737327788815-390664202cda1.mjs:12:14)
 at configResolved (file:///C:/Users/legopitstop/Documents/GitHub/Forks/quicksnip/vite.config.ts.timestamp-1737327788815-390664202cda1.mjs:21:9)
 at file:///C:/Users/legopitstop/Documents/GitHub/Forks/quicksnip/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:66405:67
 at Array.map (<anonymous>)
 at resolveConfig (file:///C:/Users/legopitstop/Documents/GitHub/Forks/quicksnip/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:66405:53)
 at async _createServer (file:///C:/Users/legopitstop/Documents/GitHub/Forks/quicksnip/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:62758:18)
 at async CAC.<anonymous> (file:///C:/Users/legopitstop/Documents/GitHub/Forks/quicksnip/node_modules/vite/dist/node/cli.js:735:20)

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not reviewable, you add too many languages at once.
Most of them not qualifying as snippets (all of the mcfunctions)

Separate different language into different pull requests and ensure snippets match the guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathys-Gasnier Mathys-Gasnier Mathys-Gasnier requested changes

@psychlone77 psychlone77 Awaiting requested review from psychlone77

@saminjay saminjay Awaiting requested review from saminjay

@majvax majvax Awaiting requested review from majvax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /