Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added the Go language with snippets #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AmeerMoustafa wants to merge 2 commits into quicksnip-dev:main from AmeerMoustafa:main
Closed

Added the Go language with snippets #208

AmeerMoustafa wants to merge 2 commits into quicksnip-dev:main from AmeerMoustafa:main

Conversation

Copy link

@AmeerMoustafa AmeerMoustafa commented Jan 7, 2025

Description

Added the Go language. Added a hello world snippet, snippets for reading/writing files and an HTTP server snippet.

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Thank you for your contribution.

After reviewing your PR we've found that all/some snippets you are adding don't match the scope of Quicksnip.
Please remove the PR that don't match the scope (Listed bellow), if your PR contains no snippet matching the scope of Quicksnip, it will be closed without further notice.

If no fix is provided within 7-10 days this PR will be closed without further notice

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not qualify as a snippet, because it is an example

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those snippets only wrap around os.ReadFile and os.WriteFile without adding anything really usefull, as such, they don't qualify as snippets under our guidelines

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not qualify as a snippet, because it is an example

Copy link
Author

Understood, I'll take my time writing a few Go snippets and come back later with another proper pull request. Thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathys-Gasnier Mathys-Gasnier Mathys-Gasnier requested changes

@majvax majvax Awaiting requested review from majvax majvax is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle γ«γ‚ˆγ£γ¦ε€‰ζ›γ•γ‚ŒγŸγƒšγƒΌγ‚Έ (->γ‚ͺγƒͺγ‚ΈγƒŠγƒ«) /