Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added sort and search algorithms to Python, updated my author name from previous pull request in C sort and search algorithms, #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
utkarshkonwar wants to merge 2 commits into quicksnip-dev:main from utkarshkonwar:main

Conversation

Copy link
Contributor

@utkarshkonwar utkarshkonwar commented Jan 6, 2025
edited
Loading

Description

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots

Copy link
Collaborator

@majvax majvax left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your contribution! πŸ™Œ

We really appreciate the effort you’ve put into submitting your Python snippets. However, we can’t accept them at this time for the following reasons:

  • Sorting: There is already a standard library equivalent in Python (sorted() or .sort() for in-place sorting). Since QuickSnip focuses on providing unique, reusable, and self-contained snippets, we avoid duplicating functionality that is already available in the standard library.

  • Search: Same for sorting, it can already be achieved using list.index() in Python. As such, it doesn’t add new or unique value to the repository.

Please resolve the conflict to update you author name.

Copy link
Collaborator

majvax commented Jan 17, 2025

Hi @utkarshkonwar ,

I'm closing this PR due to inactivity. There hasn't been any response or updates in the past week despite the requested changes.

If you'd like to continue working on this feature, please feel free to open a new PR when you have time to address the feedback. We appreciate your contribution attempt and welcome future submissions.

Thanks for understanding!

Closing as stale. πŸ‘‹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majvax majvax majvax requested changes

@psychlone77 psychlone77 Awaiting requested review from psychlone77 psychlone77 is a code owner

@saminjay saminjay Awaiting requested review from saminjay saminjay is a code owner

@Mathys-Gasnier Mathys-Gasnier Awaiting requested review from Mathys-Gasnier Mathys-Gasnier is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle γ«γ‚ˆγ£γ¦ε€‰ζ›γ•γ‚ŒγŸγƒšγƒΌγ‚Έ (->γ‚ͺγƒͺγ‚ΈγƒŠγƒ«) /