-
-
Notifications
You must be signed in to change notification settings - Fork 130
Added Rust category and a snippet #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Rust category and a snippet #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your contribution! 🙌
I had one question: shouldn’t you also check for the WAYLAND_DISPLAY environment variable? Since many modern Linux systems are moving to Wayland as a replacement for X11, it might be worth including this check.
Hey, I think you are right, i'll implement it now and push the code, thank you for the tip :).
Forget it, It is not necesary, since all the code is getting, is the desktop enviroment e.g. (gnome, xfce, i3), so we don't need to check the wayland_display.
Hey, before we move on, could you please merge main into your branch ? Making sure that /public/consolidated doesn't exist
Is it right now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good
030861d
into
quicksnip-dev:main
Description
I added the Linux category for Rust, in case people need to add related Linux code, such as desktop enviroment, etc.
Type of Change
Checklist
Related Issues
Closes #
Additional Context
Screenshots (Optional)
Click to view screenshots