Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[Snippets] add chunkArray function to array manipulation snippets #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuziferSenpai wants to merge 0 commits into quicksnip-dev:main from LuziferSenpai:main
Closed

Conversation

Copy link

@LuziferSenpai LuziferSenpai commented Jan 5, 2025 •
edited
Loading

Description

  • Added snippet to split a array into smaller chunks

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots

@LuziferSenpai LuziferSenpai changed the title (ε‰Šι™€) add chunkArray function to array manipulation snippets (ε‰Šι™€γ“γ“γΎγ§) (追記) [Snippets] add chunkArray function to array manipulation snippets (θΏ½θ¨˜γ“γ“γΎγ§) Jan 5, 2025
Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

if (!Array.isArray(array)) {
throw new TypeError('Expected an array as the first argument.');
}
if (typeof chunkSize !== 'number' || chunkSize <= 0) {
Copy link
Collaborator

@saminjay saminjay Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to specifically check for NaN, its type is number

Copy link
Author

@LuziferSenpai LuziferSenpai Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I updated it to also check for NaN.

Copy link
Collaborator

@majvax majvax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflicts by merging remote main into your main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saminjay saminjay saminjay left review comments

@majvax majvax majvax requested changes

@Mathys-Gasnier Mathys-Gasnier Mathys-Gasnier approved these changes

@psychlone77 psychlone77 Awaiting requested review from psychlone77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle γ«γ‚ˆγ£γ¦ε€‰ζ›γ•γ‚ŒγŸγƒšγƒΌγ‚Έ (->γ‚ͺγƒͺγ‚ΈγƒŠγƒ«) /