-
-
Notifications
You must be signed in to change notification settings - Fork 130
Added type check to keyboard navigation #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@christianfuttrup
christianfuttrup
requested review from
psychlone77,
saminjay and
Mathys-Gasnier
as code owners
January 4, 2025 19:38
This reverts commit 2d59cca.
psychlone77
psychlone77
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍. Thank you for your contribution.
Mathys-Gasnier
Mathys-Gasnier
approved these changes
Jan 5, 2025
@Mathys-Gasnier
Mathys-Gasnier
merged commit Jan 5, 2025
55a9225
into
quicksnip-dev:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
This pull request aims to ensure that the
switch
cases don't accept a random string from theKeyboardEvent
but rather only the ones that we expect. Furthermore, eachcase
in theswitch
statement doesn't handlepreventDefault
anymore; it has been moved to all cases that meet thekeys
we expect.Type of Change
Checklist
Related Issues
#140 (same context)