Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Snippets]: Added a new snippet for Audio Manipulation #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1982FenceHopper wants to merge 3 commits into quicksnip-dev:main from 1982FenceHopper:snippets

Conversation

Copy link

@1982FenceHopper 1982FenceHopper commented Jan 4, 2025

Description

A new folder under JavaScript was created, audio-manipulation, and a new snippet was created, web-audio-api-starter.md

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

N/A

Closes # N/A

Additional Context

I've always seen Web Audio API in raw JavaScript to be a bit tedious, so I thought to include this and hopefully more snippets in the future.

Screenshots (Optional)

N/A

Click to view screenshots

Copy link
Collaborator

Hey, Thank you for your contribution.

After reviewing your PR we've found that all/some snippets you are adding don't match the scope of Quicksnip.
Your snippets acts more like a documentation explaining how to add audio to a page, more than a snippet, providing a function (See guidelines).
I will not close your PR, if you want to fix this snippet so it's more inline with what we expect. If not feel free to close the PR

If no fix is provided within 7-10 days this PR will be closed without further notice

Copy link
Author

Ah, I see

I'll go ahead and close the PR for this then, since I have another idea for a snippet that actually is just a snippet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychlone77 psychlone77 Awaiting requested review from psychlone77 psychlone77 is a code owner

@saminjay saminjay Awaiting requested review from saminjay saminjay is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle γ«γ‚ˆγ£γ¦ε€‰ζ›γ•γ‚ŒγŸγƒšγƒΌγ‚Έ (->γ‚ͺγƒͺγ‚ΈγƒŠγƒ«) /