Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[Snippet] Added code snippet for Greatest Common Divisor in JS #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mathys-Gasnier merged 3 commits into quicksnip-dev:main from JanluOfficial:main
Jan 4, 2025

Conversation

Copy link
Contributor

@JanluOfficial JanluOfficial commented Jan 4, 2025 •
edited
Loading

Description

Added a new category in JavaScript called "Mathematical Functions", as well as a snippet in said category called "Greatest Common Divisor".

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

None

Additional Context

GCD (Greatest Common Divisor) finds the largest number that can evenly divide two or more numbers without leaving a remainder.

Screenshots (Optional)

Click to view screenshots

image

Copy link
Contributor Author

JanluOfficial commented Jan 4, 2025 •
edited
Loading

Quickly updated it with more examples since only having one felt a bit lackluster for this function. I'll let reviewers take it from here and ask me to change anything if needed.

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small little puncuation change, but appart from that it looks good

Copy link
Contributor Author

@Mathys-Gasnier will do when I'm home since I also have to re-consulidate
Mathys-Gasnier reacted with thumbs up emoji

Copy link
Contributor Author

Fixed the punctuation

@majvax majvax added mergeable Reviewed and ready to be merged Snippets labels Jan 4, 2025
@Mathys-Gasnier Mathys-Gasnier merged commit fd8d475 into quicksnip-dev:main Jan 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathys-Gasnier Mathys-Gasnier Mathys-Gasnier approved these changes

@psychlone77 psychlone77 Awaiting requested review from psychlone77 psychlone77 is a code owner

@saminjay saminjay Awaiting requested review from saminjay saminjay is a code owner

Assignees
No one assigned
Labels
mergeable Reviewed and ready to be merged Snippets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle γ«γ‚ˆγ£γ¦ε€‰ζ›γ•γ‚ŒγŸγƒšγƒΌγ‚Έ (->γ‚ͺγƒͺγ‚ΈγƒŠγƒ«) /