Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adding the dart language #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CreeperFarm wants to merge 2 commits into quicksnip-dev:main from CreeperFarm:main
Closed

Conversation

Copy link

@CreeperFarm CreeperFarm commented Jan 3, 2025
edited
Loading

Description

Adding the dart language with 2 category:

  • Basic
    • Hello World
  • Flutter
    • Button ElevatedButton
    • Button InkWell
    • Custom Icon

Type of Change

  • ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe): Adding a new language

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable). (Not applicable here)
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

It could be great if we can add images to show the result for ui

Screenshots (Optional)

Click to view screenshots

Basic category :

image

Flutter category :

image image

Copy link
Collaborator

Hey, Thank you for your contribution.

After reviewing we notice that your PR doesn't follow our guidelines.
You can find them in CONTRIBUTING.md in the root of the repo. If you have any question or want to contest this decision please send a message in your PR explaining your position.

If no fix is provided within 7-10 days this PR will be closed without further notice

@Mathys-Gasnier Mathys-Gasnier added Snippets Guidelines Issue Your PR has been found to not follow the CONTRIBUTING.md guidelines labels Jan 3, 2025
Copy link
Author

Which guidelines have I infringed so that I can do the changes.

Copy link
Collaborator

The icon is the wrong size, and looking at them more i don't think the snippets fit the scope of the project, but let's get another opinion on that

Making the icon a 50x50px.
Removing the flutter tags from the two button snippets and the custom icons.
Adding the Usage for the custom icon.
Copy link
Author

I just correct the size of the image and some other things that could be taken as infringement.

Copy link
Collaborator

majvax commented Jan 3, 2025

Thank you for your contribution and for taking the time to submit these snippets! However, after reviewing your PR, I believe that the snippets you’ve provided don’t fully align with the scope of QuickSnip.

The primary focus of QuickSnip is on self-contained functions that perform a specific task or solve a problem in a concise and reusable way. Your snippets, while useful, seem to focus more on UI components (e.g., how to create a button or widget that performs an action on click). These types of snippets are more about UI implementation rather than standalone, reusable logic.

While we might need to close this PR, If you’d like to adapt your snippets to better fit the scope of QuickSnip, I’d be happy to review them again! For example, instead of focusing on how to create a button, you could create a snippet for a utility function that handles a common task related to buttons or widgets (e.g., debouncing a click event, toggling a state, etc.)

Copy link
Author

Do you think that explaining how provider works could be a good idea ?

Copy link
Collaborator

Quicksnip doesn't work like a document, we don't explain how stuff works, we provide usefull snippets of code that people can use in their codebases

Copy link
Author

Alright then I close this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majvax majvax Awaiting requested review from majvax majvax is a code owner

@Mathys-Gasnier Mathys-Gasnier Awaiting requested review from Mathys-Gasnier Mathys-Gasnier is a code owner

Assignees
No one assigned
Labels
Guidelines Issue Your PR has been found to not follow the CONTRIBUTING.md guidelines Snippets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /