-
-
Notifications
You must be signed in to change notification settings - Fork 128
Add Sieve of Eratosthenes algorithm snippet in C++ #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the dot . after the colon :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, Thanks for you contribution.
This seems to be a promising PR. However I have few comments to make
-
Fix the issue on line 26
-
Performance improvement discussion
I’ve benchmarked your snippet, and it currently takes up to 500ms to calculate all prime numbers up to1e7 + 1. While this is functional, I believe there’s room for optimization.- Have you considered using the C++20
constevalkeyword to compute the primes at compile time? This could significantly improve runtime performance by shifting the computation to compile time. - Additionally, I’ve observed better performance when using
std::bitset, which is a fixed-size array. It might be worth exploring this as an alternative to your current implementation.
- Have you considered using the C++20
Fix the issue, let me know your thoughts on these suggestions, and feel free to reach out if you’d like to discuss them further.
...set for better efficiency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update this line too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I say to update the usage section, I meant to update the way you call it. Since isPrime is no longer a global variable, you need to get it from the return value of computeSieve...
Hi @muriloguizelin,
I'm closing this PR due to inactivity. There hasn't been any response or updates in the past week despite the requested changes.
If you'd like to continue working on this feature, please feel free to open a new PR when you have time to address the feedback. We appreciate your contribution attempt and welcome future submissions.
Thanks for understanding!
Closing as stale. 👋
Description
Added a new snippet for the Sieve of Eratosthenes algorithm, which efficiently generates all prime numbers up to a given maximum value. The code demonstrates the classic sieve approach with an optimized marking process for identifying primes.
Type of Change
Checklist
Related Issues
Closes #
Additional Context
This snippet provides an efficient implementation of the Sieve of Eratosthenes to calculate primes. It's suitable for use in applications that require prime number generation up to a specified maximum limit.
Screenshots (Optional)
Click to view screenshots