-
-
Notifications
You must be signed in to change notification settings - Fork 130
Adding support for sub languages on the "backend" #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mathys-Gasnier
Mathys-Gasnier
requested review from
psychlone77 and
saminjay
as code owners
January 3, 2025 16:22
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The preview doesn't work because the consolidation hasn't run, i'm going to push a commit manually doing it
technoph1le
technoph1le
approved these changes
Jan 4, 2025
majvax
majvax
approved these changes
Jan 5, 2025
@Mathys-Gasnier
Mathys-Gasnier
merged commit Jan 5, 2025
3f3137a
into
quicksnip-dev:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to parse sub languages to the snippet parser, and to consolidate them.
To consolidate them we save the json and svg with the following name format
language--subLanguage.I didn't want to put them under folders as i think it would complexify things in the frontend.
Also, as we are using slugify to generate the
languageandsubLanguagename, a--can never occur outside of that usecase.As it stands we support only 1 level of nesting languages.
Some small changes also include renaming some names key to
name(langin_index.jsonandcategoryName)Type of Change
Checklist
Related Issues
Related to #136