-
Notifications
You must be signed in to change notification settings - Fork 125
Use shadcn components #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
psychlone77
commented
Jan 3, 2025
Instead of ignoring the components/ui folder, we could run npm run lint -- --fix to fix those issues. Since those files are also technically part of the codebase which could be modified in the future, better to have those files also kept properly.
mayur1377
commented
Jan 3, 2025
Instead of ignoring the
components/uifolder, we could runnpm run lint -- --fixto fix those issues. Since those files are also technically part of the codebase which could be modified in the future, better to have those files also kept properly.
agree , but it would literally just be an overkill , to keep running it each and every time to fix the linting errors for the already pre built components
i would recommend two option here ,
-> ignore the components/ui folder which has all the pre-built shad-cn components which might hardly require some changes
-> just add the npm run lint fix command to the workflow file
Screenshot 2025年01月03日 at 9 17 36 PM
Mathys-Gasnier
commented
Jan 3, 2025
I'm too thinking we should ignore the components from shad-cn, it will just be a pain to reformat them each time.
psychlone77
commented
Jan 3, 2025
agree , but it would literally just be an overkill , to keep running it each and every time to fix the linting errors for the already pre built components.
i would recommend two option here ,
-> ignore the components/ui folder which has all the pre-built shad-cn components which might hardly require some changes
-> just add the npm run lint fix command to the workflow file
We will only have to fix the linting errors once when someone adds a new 'shadcn component' to the project. Since 'shadcn' components is still someone else' s code and we are technically just copy pasting the components into the project, we should still make sure that code follows the project's eslint rules.
Running npm run lint -- --fix is an option, but might introduce changes which the person who made the commit might not have expected. It's better for the build to fail and show where error was, instead of it automatically making changes.
any updates of still using shadcn?
Mathys-Gasnier
commented
Jan 8, 2025
Fix conflicts and errors of your PR before we review again
112452c to
5880f02
Compare
jjcantu
commented
Jan 10, 2025
@Mathys-Gasnier I think we should probably open up another MR for this. It is blocking a lot of other developers from contributing.
Description
add shad-cn components
Type of Change
note : there are some linting errors from the already pre-built shad-cn components , would recommend to disable folder that folder