-
-
Notifications
You must be signed in to change notification settings - Fork 128
Added string split snippet in CPP #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you prehaps add includes to the snippets ?
It would allow users to see what is used in your snippet even before using it !
@Mathys-Gasnier Done.
Should I also add includes to the other CPP snippets?
It also needs a using namespace std.
I think yeah adding includes to other example is a good thing...
But not using namespace std it's not a good practice to use it, it can introduce name conflict among other things
Yes, it is a bad practice. That's why I didn't use it in my snippet but the other snippet doesn't include std::. If I am fixing that, I would either have to add std:: in the snippet or add using namespace std;. Not sure which one @dostonnabotov would prefer.
@saminjay and @Mathys-Gasnier Thank you for taking your time to review the snippet before submitting it. I'm not very familiar with C++, so I can't help you with this one. You can decide yourselves on which one to implement.
@Mathys-Gasnier @dostonnabotov Done.
I've added the namespace scope operator std:: and includes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
Added a new snippet, to split a string in CPP