Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Scss dark theme #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mathys-Gasnier merged 8 commits into quicksnip-dev:main from gihanrangana:scss-dark-theme
Jan 2, 2025
Merged

Conversation

Copy link
Contributor

@gihanrangana gihanrangana commented Jan 2, 2025 •
edited
Loading

Description

Added new snippet for SCSS under the layouts category. which is helpful to change styles for dark themes

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

#112

Closes #

Additional Context

This is the working demo for my snippet
https://stackblitz.com/edit/react-hook-usedarkmode

Screenshots (Optional)

Click to view screenshots

Copy link

netlify bot commented Jan 2, 2025 •
edited
Loading

βœ… Deploy Preview for quicksnip ready!

Name Link
πŸ”¨ Latest commit 5f89951
πŸ” Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/677669462be41c0008c8c731
😎 Deploy Preview https://deploy-preview-113--quicksnip.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor Author

@gihanrangana gihanrangana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the snippet formating

Copy link
Collaborator

I don't understand why the syntax is failing on your PR, i'm going to have a look at that, before reviewing

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow checking snippets fails because you are using CRLF line endings \r\n instead on LF ones with just a \n

@technoph1le technoph1le added the update needed Code needs to be updated. label Jan 2, 2025
Copy link
Contributor Author

The workflow checking snippets fails because you are using CRLF line endings \r\n instead on LF ones with just a \n

thanks, i have updated CRLF to LF

@Mathys-Gasnier Mathys-Gasnier merged commit e74409d into quicksnip-dev:main Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathys-Gasnier Mathys-Gasnier Mathys-Gasnier approved these changes

Assignees
No one assigned
Labels
update needed Code needs to be updated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle γ«γ‚ˆγ£γ¦ε€‰ζ›γ•γ‚ŒγŸγƒšγƒΌγ‚Έ (->γ‚ͺγƒͺγ‚ΈγƒŠγƒ«) /