-
-
Notifications
You must be signed in to change notification settings - Fork 130
Codebase spell checker #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codebase spell checker #102
Conversation
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to add a CI or edit an existing one to run all linting, cspell, and all of that ?
Appart from that it looks wonderfull
It also looks like your eslint config broke the CI, could you look at that ? No idea what caused it
It also looks like your eslint config broke the CI, could you look at that ? No idea what caused it
On main currently if npm run lint
is executed there seems to be an error in useLanguages.tsx
. Maybe these were merged around the same time before this file could be correctly linted?
I fixed it, was due to the node version being 16 and eslint v9 supporting only node v18+
It also looks like your eslint config broke the CI, could you look at that ? No idea what caused it
@Mathys-Gasnier I think it may actually be that we're using an older version of node:
Screenshot 2025年01月01日 at 21 00 00
Switching to node v16.20.2
causes the same error on local:
Screenshot 2025年01月01日 at 21 02 29
I fixed it, was due to the node version being 16 and eslint v9 supporting only node v18+
You found the same issue as me, thanks 😄
Would you be able to add a CI or edit an existing one to run all linting, cspell, and all of that ?
Appart from that it looks wonderfull
Let me take a look at this.
@Mathys-Gasnier Just merged the latest changes; should the following be "contents" and not "content"?
check-snippets.yml
Screenshot 2025年01月01日 at 21 08 37
It should yeah, i'm going to push a commit fixing the typo
@Mathys-Gasnier I've added a new workflow "pre-commit-checks.yml" which seems to be working correctly. Currently it will execute on push and pull_request for any branch or PR, but feel free to changes this if it is not restrictive enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can keep it just on pull requests, we only really need to check this when merging a PR
I think you can keep it just on pull requests, we only really need to check this when merging a PR
This has been changed.
Looks magnificent, let's wait on another review and we can then merge this
As you fixed what @psychlone77 said, I think we are safe to merge this, great work !
d00e21b
into
quicksnip-dev:main
Uh oh!
There was an error while loading. Please reload this page.
Description
cspell
packagecspell-dict.txt
will be ignoredpre-commit-checks.yml
Type of Change
Checklist
Related Issues
Closes #82
Additional Context
Screenshots (Optional)
Click to view screenshots