-
Notifications
You must be signed in to change notification settings - Fork 334
feat(testing): New testing feature to enable running both a acceptor and initiator in the same process. #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fe84040 to
825abc4
Compare
kcross-ctoken
commented
Dec 17, 2024
@ackleymi ... thoughts ?
kcross-ctoken
commented
Jan 8, 2025
kcross-ctoken
commented
Jan 21, 2025
@ekovacs ?
ackleymi
commented
Jan 23, 2025
This has backwards compatibility, correct? Quite a lot of changes in here, but it certainly has a lot of benefits
Quite a lot of changes in here, but it certainly has a lot of benefits
yup it does ... the functions in file provide the backwards compatibility also the existing "integration" tests should give some confidence in this too.
kcross-ctoken
commented
Jan 29, 2025
@ackleymi ... can we get this merged sometime soon so I don't need to keep rebasing my fork ?
@ackleymi, @michaelwilner .... is there a reason not to merge this ?
kcross-ctoken
commented
Feb 10, 2025
@ackleymi, @michaelwilner .... is there a reason not to merge this ?
Do we have any active developers in this project ?
michaelwilner
commented
Feb 10, 2025
@ackleymi, @michaelwilner .... is there a reason not to merge this ?
Do we have any active developers in this project ?
When merging larger changes like this we have to be aware of the impact to the larger community as this project has a lot of users, many of which are institutional. We are absolutely considering this PR, please be patient
kcross-ctoken
commented
Feb 14, 2025
Thanks for the feedback.
f6a64c7 to
173a053
Compare
173a053 to
5fa7f1b
Compare
When merging larger changes like this we have to be aware of the impact to the larger community as this project has a lot of users, many of which are institutional. We are absolutely considering this PR, please be patient
@ackleymi, @michaelwilner Can you please update ... this is now causing some considerable pain on my side.
This fix is backward compatible and enables better testing so its a win win all cases.
kcross-ctoken
commented
May 28, 2025
When merging larger changes like this we have to be aware of the impact to the larger community as this project has a lot of users, many of which are institutional. We are absolutely considering this PR, please be patient
@ackleymi, @michaelwilner Can you please update ... this is now causing some considerable pain on my side. This fix is backward compatible and enables better testing so its a win win all cases.
Uh oh!
There was an error while loading. Please reload this page.
This PR adds the ablity to have a registry per instance of initiator or acceptor and not have session conflicts.
The main purpose of this is to allow in process testing of both initiator and Acceptor.
There is an example test service_test which does the whole setup and routing between initiator and acceptor in the same process.
This would also allow the "integration" or service tests to run against eachother without the need for a deployed service or a docker image. Using this technique will require less resources for running tests and they will run a lot faster.