-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[WIP][Add] Mask2Former #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
[WIP][Add] Mask2Former #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @qubvel some questions before I start contributing to the core part of the model:
- This model seems to have three parts, a pixel encoder, a pixel decoder and a transformer decoder. While I understand that I do not have to write the pixel encoder, as that can be directly retrieved from
timm
, the only bits I would need to contribute right now would be the two decoders. - Do we want this to be inference only at first? To make this happen my workflow would be to copy code from the
transformers
implementation and make the weight conversion (only if required) and pass an image to the model to see the semgentation maps correctly. - I am unsure about the processor. Do you think we should concentrate on that as well?
Let me know what you think.
Hey @ariG23498, thanks for the questions, I tried to answer them, but let me know if anything is unclear
- Yes
- AFAIU the semantic segmentation model should be trainable with existing tutorials, otherwise, we can make a new tutorial (if there are any nuances)
- We can use Albumentations for preprocessing - similar to what I used for segformer + to create a notebook on how to make an inference. See also the snippet for Segformer https://huggingface.co/smp-hub/segformer-b3-512x512-ade-160k
Hi @ariG23498, are you still working on this issue? If not, I would like to take it up.
Hey @vedantdalimkar feel free to take this up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1044