-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Fix[Build]: Stop removing runnable code from skipped tutorials in sharded build #3754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3754
- 📄 Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
❌ 15 New Failures
As of commit ebc549f with merge base b99753a (image ):
NEW FAILURES - The following jobs have failed:
- Build tutorials / build / pytorch_tutorial_build_worker (1, 15, linux.g5.12xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (10, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (11, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (12, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (13, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (14, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (15, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (2, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (3, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (4, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (5, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (6, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (7, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (8, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100. - Build tutorials / build / pytorch_tutorial_build_worker (9, 15, linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 100.
This comment was automatically generated by Dr. CI and updates every 15 minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3734
Description
The get_files_to_run.py script was aggressively scrubbing code from files not in the current shard. This caused the RUNNABLE_CODE_REMOVED placeholder to appear in the Unstable docs when artifacts were merged. This PR disables the remove_other_files step, ensuring source files remain intact while files_to_run still controls execution order.
Checklist