-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Simplify training progress logging to avoid reliance on global batch_size. #3749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify training progress logging to avoid reliance on global batch_size. #3749
Conversation
🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3749
- 📄 Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
This comment was automatically generated by Dr. CI and updates every 15 minutes.
Hi @UtkarshSingh31!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Uh oh!
There was an error while loading. Please reload this page.
Description
This PR simplifies the computation of the training progress counter (
current) in the optimization tutorial.The existing example computes
currentusing a globalbatch_sizevariable. While this works in the current context, it introduces an unnecessary dependency on global state and can make the example harder to reason about or reuse if modified.Computing
currentasbatch * len(X)directly reflects the number of samples processed so far, avoids reliance on external assumptions, and naturally handles variable batch sizes.This change affects logging only and does not modify training behavior or results.
Checklist
Happy to adjust wording or implementation if there is a preferred tutorial style.