-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Fix backpropagation order in optimization tutorial #3676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patrocinio
wants to merge
2
commits into
pytorch:main
from
patrocinio:3507_Optmizing_Model_Parameters
Open
Fix backpropagation order in optimization tutorial #3676
patrocinio
wants to merge
2
commits into
pytorch:main
from
patrocinio:3507_Optmizing_Model_Parameters
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3676
- 📄 Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
✅ No Failures
As of commit f4e16a7 with merge base 7f8b6dc (image ):
💚 Looks good so far! There are no failures yet. 💚
This comment was automatically generated by Dr. CI and updates every 15 minutes.
Reorder optimizer.zero_grad(), loss.backward(), and optimizer.step() to match the recommended best practice documented in the tutorial. Fixes pytorch#3507
@patrocinio
patrocinio
force-pushed
the
3507_Optmizing_Model_Parameters
branch
from
December 3, 2025 15:03
7e70fc2 to
ed984c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder optimizer.zero_grad(), loss.backward(), and optimizer.step() to match the recommended best practice documented in the tutorial.
Fixes #3507
Description
Checklist