-
Notifications
You must be signed in to change notification settings - Fork 52
Fix return type for name property in Credentials class. #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DrFobos
DrFobos
force-pushed
the
main
branch
2 times, most recently
from
February 17, 2025 16:56
7278672 to
da7fdc3
Compare
jborean93
jborean93
approved these changes
Feb 17, 2025
Hey sorry the CI workers were a bit old so I had to update them in #353 to get CI passing. Would you be able to rebase this PR so it runs with the latest changes before I merge it in?
...est checks. Signed-off-by: Aleksey Kondratov <drfobos91@mail.ru>
@DrFobos
DrFobos
force-pushed
the
main
branch
from
February 18, 2025 07:11
da7fdc3 to
55d527d
Compare
Sure, no problem.
jborean93
jborean93
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like type annotation for name property in gssapi.creds.Credentials class should be gssapi.names.Name rather than gssapi.raw.names.Name.
Because it explicitly casts in gssapi.creds.Credentials.inquire.
Change return type and add checks into tests.