-
Notifications
You must be signed in to change notification settings - Fork 52
really drop python<=3.7 support #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Filter all code over `pyupgracde --py38-plus`. Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
BTW end of this month 3.8 will be EOSed.
This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.
Any update? 🤔
Sorry I didn't get to this earlier. I'm reluctant to merging in stylistic changes without having an actual check in CI to back it for future commits. Granted there are still some Python 2-isms still in there that this PR is fixing but making these changes doesn't really achieve to much in the long run.
If I was really wanting to do something like this I would prefer to just have something like black to go over the codebase.
black is the Python code formatter.
pyupgrade replaces syntax to more effective handled by exact Python version (please read pyupgrade documentation for details).
gssapi passes pytest test suite with this PR.
Did you test this PR? 🤔
This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.
Filter all code over
pyupgracde --py38-plus.