Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

really drop python<=3.7 support #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kloczek wants to merge 2 commits into pythongssapi:main
base: main
Choose a base branch
Loading
from kloczek:main
Open

Conversation

Copy link

@kloczek kloczek commented Oct 3, 2024

Filter all code over pyupgracde --py38-plus.

kloczek added 2 commits October 3, 2024 05:53
Filter all code over `pyupgracde --py38-plus`.
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Copy link
Author

kloczek commented Oct 3, 2024

BTW end of this month 3.8 will be EOSed.

Copy link

github-actions bot commented Nov 1, 2024

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

Copy link
Author

kloczek commented Nov 1, 2024

Any update? 🤔

Copy link
Contributor

Sorry I didn't get to this earlier. I'm reluctant to merging in stylistic changes without having an actual check in CI to back it for future commits. Granted there are still some Python 2-isms still in there that this PR is fixing but making these changes doesn't really achieve to much in the long run.

If I was really wanting to do something like this I would prefer to just have something like black to go over the codebase.

Copy link
Author

kloczek commented Nov 13, 2024

black is the Python code formatter.
pyupgrade replaces syntax to more effective handled by exact Python version (please read pyupgrade documentation for details).
gssapi passes pytest test suite with this PR.
Did you test this PR? 🤔

Copy link

github-actions bot commented Sep 2, 2025

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /