Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update setup.py #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanglist wants to merge 1 commit into pythongssapi:main from sanglist:main
Closed

Update setup.py #331

sanglist wants to merge 1 commit into pythongssapi:main from sanglist:main

Conversation

Copy link

@sanglist sanglist commented Oct 30, 2023

Small fix to enable vas_gssapi
Signed-off-by: Shlomo Anglister shlomo.anglister@intel.com

Small fix to enable vas_gssapi
Signed-off-by: sanglist <shlomo.anglister@intel.com>
Copy link

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

Copy link
Author

Please merge to resolve setup issue

Copy link
Contributor

simo5 commented Nov 29, 2023

@jborean93 this patch looks sane enough, ok if I merge it?

sanglist reacted with thumbs up emoji

Copy link
Contributor

jborean93 commented Nov 29, 2023
edited
Loading

Sorry this one was lost in my sea of notifications. At a glance it seems ok but I do wonder if it might potentially pick up some false positive match with some options where we may want to be a bit more selective for this particular scenario.

sanglist reacted with thumbs up emoji

Copy link
Author

Sorry this one was lost in my sea of notifications. At a glance it seems ok but I do wonder if it might potentially pick up some false positive match with some options where we may want to be a bit more selective for this particular scenario.

Agreed but - it's a bug fix
Would appreciate you improving it.

Copy link
Contributor

jborean93 commented Nov 30, 2023
edited
Loading

I only want to approve it when I know it won't break other use cases. What setup is causing the problem here is it a specific distro/package. What is the output of krb5-config --libs gssapi, is there potentially a better way of fixing your problem.

Copy link
Author

I only want to approve it when I know it won't break other use cases. What setup is causing the problem here, what is the output of krb5-config --libs gssapi and is there potentially a better way of fixing your problem.

On SLES12 (SuSE 12 Enterprise)

-Wl,-rpath,/opt/quest/lib64:/opt/quest/lib64/support -L/opt/quest/lib64 -lvas -L/opt/quest/lib64/support -lgcc_s -lvas-gssapi -lrt -lresolv

Copy link
Contributor

Thanks, is vas-gssapi just a SLES thing or is it a specific package here? I'm afraid I'm not familiar with it.

Copy link
Author

It depends on corporate, right ?
bridging all kinds of authentication protocols originating from a vast application space to corporate authentication.

Copy link
Contributor

What I’m trying to get at is how can I test out this scenario. If I need to maintain this I need to know who could be affected and what scenarios this code needs to handle. Do you have any info on this vas-gssapi library. Is it a product I can install or is it a paid product. Are there docs online about it that you can share.

Copy link
Author

The solution at: pykrb5/setup.py
Seems to provide a one size fits all using environment variables.

Copy link

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /