-
Notifications
You must be signed in to change notification settings - Fork 52
Fix OID inequality comparison #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OID inequality comparison #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small test comment, otherwise fine.
gssapi/tests/test_raw.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this (krb5 == krb5_other).should_be(True) so that we get nice error messages with should_be
Good catch.
/me is embarrased
Due to an extraneous 'or' branch, OID inequality comparison would return the results of an equality comparison. Signed-off-by: Alexander Scheel <ascheel@redhat.com>
c7d80a4 to
bc32062
Compare
Thank you! Updated :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Due to an extraneous 'or' branch, OID inequality
comparison would return the results of an equality
comparison.