-
Notifications
You must be signed in to change notification settings - Fork 288
Change the typing spec around string references#2144
Change the typing spec around string references #2144davidhalter wants to merge 9 commits intopython:main from
Conversation
davidhalter
commented
Jan 4, 2026
@JelleZijlstra Could you please pre-review this? What do you think about this spec change?
davidhalter
commented
Jan 6, 2026
I think I have integrated all the changes. Is it time to open an issue on the Typing Council’s issue tracker asking for a decision?
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@carljm
carljm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One wording nit, one formatting nit, and one conformance suite nit :) But overall this looks great to me.
@rchen152
rchen152
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - much more consistent and clearly specified than before
...cope This fix was proposed by Carl
@carljm
carljm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks @davidhalter for getting this clarified.
davidhalter
commented
Jan 29, 2026
I have integrated all of Carl's suggestions. I will update the conformance tests as soon as the typing council approves this change. If I update it now we probably just run into merge conflicts, since especially pyrefly changes a lot.
@carljm Please let me know if you think something needs more work.
Uh oh!
There was an error while loading. Please reload this page.
I added this after the discussion here: https://discuss.python.org/t/annotation-string-references-in-class-scope-in-conformance-tests/105439
I'm not 100% sure about the wording, but I hope the direction is fine. I would like to gather some feedback before presenting this to the typing council.
Please also merge #2139 before this pull request. Otherwise it will be very hard to update Zuban's conformance test results in this pull request.