-
Notifications
You must be signed in to change notification settings - Fork 288
Delete "Passing kwargs inside a function to another function section"#1960
Open
yangdanny97 wants to merge 1 commit intopython:main from
Open
Delete "Passing kwargs inside a function to another function section" #1960yangdanny97 wants to merge 1 commit intopython:main from
yangdanny97 wants to merge 1 commit intopython:main from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The context is in example 2 from #1918
It doesn't make sense to enforce this requirement for just
**kwargsbut not any other arguments annotated with a TypedDict, and additionally, no typecheckers currently implement this.It seems like https://discuss.python.org/t/typing-spec-inconsistency-for-unpacking-typed-dict-kwargs/79640 didn't get any responses. I'll bump the discussion again but for now I'll make a PR here so I don't forget about it.