-
-
Notifications
You must be signed in to change notification settings - Fork 33k
[3.14] gh-138489: Add missing build-details.json step for building wasm (GH-139302)
#139557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@miss-islington
miss-islington
requested a review
from erlend-aasland
as a code owner
October 4, 2025 13:47
...asm (pythonGH-139302) * fix: add missing `build-details.json` step for building wasm Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> * pythongh-138489: Add missing build-details.json step for building wasm Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> * Update Makefile.pre.in Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> --------- (cherry picked from commit db53ca3) Co-authored-by: Ho Kim <ho.kim@ulagbulag.io> Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@miss-islington
miss-islington
force-pushed
the
backport-db53ca3-3.14
branch
from
October 4, 2025 14:25
ff0c6ac to
8cbc4bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-details.jsonstep for building wasmSigned-off-by: Ho Kim ho.kim@ulagbulag.io
build-details.jsonis missing on some platforms #138489 : Add missing build-details.json step for building wasmSigned-off-by: Ho Kim ho.kim@ulagbulag.io
Co-authored-by: Adam Turner 9087854+AA-Turner@users.noreply.github.com
(cherry picked from commit db53ca3)
Co-authored-by: Ho Kim ho.kim@ulagbulag.io
Signed-off-by: Ho Kim ho.kim@ulagbulag.io
Co-authored-by: Adam Turner 9087854+AA-Turner@users.noreply.github.com