-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
gh-138250: load fast optimization should fall through to empty blocks #138249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DinoV
DinoV
changed the title
(削除) load fast optimization should fall through to empty blocks (削除ここまで)
(追記) gh-138250: load fast optimization should fall through to empty blocks (追記ここまで)
Aug 29, 2025
mpage
mpage
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - fixes a bug and is much cleaner!
@bedevere-app
bedevere-app
bot
added
awaiting merge
and removed
awaiting core review
labels
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
In code like:
The compiler ends up producing an empty basic block. When the load fast optimization runs it sees that
term == NULL
and doesn't fall through to the following block. The end result is that the compiler doesn't properly produce aLOAD_FAST_BORROWED_LOAD_FAST_BORROWED
opcode.The analysis should just use the
BB_HAS_FALLTHROUGH
macro instead of duplicating the logic.