Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

gh-101100: Resolve reference warnings in library/xml.sax.handler.rst #136612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@LamentXU123 LamentXU123 commented Jul 13, 2025 •
edited
Loading

There are two warnings:

C:\Users\admin\Downloads\cpython-main\Doc\library\xml.sax.handler.rst:249: WARNING: py:class reference target not found: xml.sax.xmlreader.Attributes [ref.class]
C:\Users\admin\Downloads\cpython-main\Doc\library\xml.sax.handler.rst:271: WARNING: py:class reference target not found: xml.sax.xmlreader.AttributesNS [ref.class]

This warning happens in many doc of xml (xml.sax.reader, xml.sax.handler, xml.sax) in the same reason. After staring the doc for a while, I think the original doc want to refer to xml.sax.xmlreader.AttributesImpl and xml.sax.xmlreader.AttributesNSImpl as an implemention of attributes-interface. This doc fix it to the correct ref.

If this is approved, I will fix up those occurrence in other docs, an example of this in xml.sax is as below to double check.

image

📚 Documentation preview 📚: https://cpython-previews--136612.org.readthedocs.build/

@LamentXU123 LamentXU123 changed the title (削除) gh-101100: Fix sphinx warnings in library/xml.sax.rst (削除ここまで) (追記) gh-101100: Fix sphinx warnings in library/xml.sax.handler.rst (追記ここまで) Jul 14, 2025
Copy link
Contributor Author

Fixed to:
image

@LamentXU123 LamentXU123 marked this pull request as ready for review July 14, 2025 15:27
@AA-Turner AA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed awaiting merge labels Sep 3, 2025
@AA-Turner AA-Turner changed the title (削除) gh-101100: Fix sphinx warnings in library/xml.sax.handler.rst (削除ここまで) (追記) gh-101100: Resolve reference warnings in library/xml.sax.handler.rst (追記ここまで) Sep 3, 2025
@AA-Turner AA-Turner merged commit c22cc8f into python:main Sep 3, 2025
38 checks passed
Copy link

Thanks @LamentXU123 for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2025 
...r.rst (pythonGH-136612)
(cherry picked from commit c22cc8f)
Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2025 
...r.rst (pythonGH-136612)
(cherry picked from commit c22cc8f)
Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
Copy link

bedevere-app bot commented Sep 3, 2025

GH-138421 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 3, 2025
Copy link

bedevere-app bot commented Sep 3, 2025

GH-138422 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 3, 2025
AA-Turner pushed a commit that referenced this pull request Sep 3, 2025 
...er.rst (GH-136612) (#138422)
Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
hugovk pushed a commit that referenced this pull request Sep 3, 2025 
...er.rst (GH-136612) (#138421)
gh-101100: Resolve reference warnings in library/xml.sax.handler.rst (GH-136612)
(cherry picked from commit c22cc8f)
Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@AA-Turner AA-Turner AA-Turner approved these changes

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /