-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
gh-93096: Move random benchmark into pyperformance - #131144
Conversation
donbarbos
commented
Mar 12, 2025
cc @vstinner
:-)
@vstinner
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cc @hugovk
rhettinger
commented
Mar 12, 2025
This isn't a performance test. It is used by module maintainers to view generated distributions to see if they match the expected distributions.
donbarbos
commented
Mar 12, 2025
I think it would be right to get rid of the --test flags in modules with cli.
This flag is not documented and is not displayed in the --help output.
And it seems author of this flag is not against removing it
rhettinger
commented
Mar 20, 2025
I'm going to decline this. It isn't part of the public API so there is no user benefit to removing it. I do use this when maintaining the module so it does have some value. And the test code has nothing to do with pyperformance so this PR would be moving the code from where a mainainer can find it to a place where it clearly doesn't make sense.
Uh oh!
There was an error while loading. Please reload this page.
This PR couples with python/pyperformance#386
Inspired by #94613