Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Test running pyt in a python 3.7 env #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinHock merged 1 commit into python-security:master from bcaller:py37
Jan 19, 2019
Merged

Conversation

Copy link
Collaborator

@bcaller bcaller commented Jan 16, 2019
edited
Loading

It should just work. There were no AST changes.

Also removes the unnecesary whitelist_external from tox.ini.

Note: pyt can be run in a py36 environment on code targeting 2.7-3.8.
There is no requirement for pyt to be run under the same environment as
your code is intended to run in.

Running pyt under 3.8 will require some further work due to the change
from ast.Str to ast.Constant:
https://github.com/python/cpython/pull/9445/files
https://docs.python.org/dev/whatsnew/3.8.html#deprecated
https://bugs.python.org/issue32892

Closes #192

It should just work. There were no AST changes.
Also removes the unnecesary whitelist_external from tox.ini.
Note: pyt can be run in a py36 environment on code targeting 2.7-3.8.
There is no requirement for pyt to be run under the same environment as
your code is intended to run in.
Running pyt under 3.8 will require some further work due to the change
from ast.Str to ast.Constant:
https://github.com/python/cpython/pull/9445/files
https://docs.python.org/dev/whatsnew/3.8.html#deprecated
https://bugs.python.org/issue32892 
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KevinHock KevinHock merged commit 54df18e into python-security:master Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinHock KevinHock KevinHock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /