-
Notifications
You must be signed in to change notification settings - Fork 250
Recursive function calls shouldn't raise RecursionError #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store a stack of definitions. If you revisit a function, treat it as a blackbox. The non-recursive return values should still propagate.
recur_but_no_propagation is actually safe, but it would be difficult to reliably determine this, so we'll have to do with the false positive at least for now (as recursive functions can call other recursive functions).
This happened to me the other day, thank you so much for making this! :D 🎊
KevinHock
KevinHock
approved these changes
Sep 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll try to make a new release on Monday or Tuesday
p.s. Happy to give you PyPI access and GitHub write access 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store a stack of definitions.
If you revisit a function, treat it as a blackbox.
The non-recursive return values should still propagate.