-
Notifications
You must be signed in to change notification settings - Fork 250
Deterministic file loading and vulnerability order #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os.walk is not deterministic (though often on the same computer it will walk in the same order). This means that the vulnerabilities appear in different orders on different machines, making it hard to compare output. Process files in alphabetical order.
The project_modules only need loading once if -pr is set, not once for every file.
KevinHock
KevinHock
approved these changes
Aug 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
directory = os.path.normpath(args.project_root)
project_modules = get_modules(directory, prepend_module_root=args.prepend_module_root)
for path in sorted(files):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a great idea I don't think I would have ever thought of 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.walkis not deterministic (though often on the same computer it willwalk in the same order).
This means that the vulnerabilities can appear in different orders, making it hard to compare output.
Process files in alphabetical order.
I do need to look more deeply into how the import system works because I think there are some other non-determinism problems which can result in vulnerabilities not being found but I haven't figured it out yet.