-
-
Notifications
You must be signed in to change notification settings - Fork 417
Comments
Fix incorrect subtract result in documentation#941
Open
daniel7an wants to merge 1 commit intopython-pendulum:master from
Open
Fix incorrect subtract result in documentation #941daniel7an wants to merge 1 commit intopython-pendulum:master from
daniel7an wants to merge 1 commit intopython-pendulum:master from
Conversation
The result of dt.subtract(minutes=24) from 01:01:00 should be 00:37:00, not 00:00:00. Fixes python-pendulum#925
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #925
The result of
dt.subtract(minutes=24)from01:01:00was incorrectly shown as00:00:00instead of00:37:00in the addition/subtraction docs.