Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Simplify and unify UNIX timezone retrival#938

Open
Secrus wants to merge 1 commit intopython-pendulum:master from
Secrus:unix-timezone
Open

Simplify and unify UNIX timezone retrival #938
Secrus wants to merge 1 commit intopython-pendulum:master from
Secrus:unix-timezone

Conversation

@Secrus
Copy link
Collaborator

@Secrus Secrus commented Jan 30, 2026
edited
Loading

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Closes: #837
Closes: #840
Closes: #829

@Secrus Secrus requested a review from ashb January 30, 2026 14:29
Copy link

codspeed-hq bot commented Jan 30, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing Secrus:unix-timezone (150aa01) with master (aea611d)

Summary

✅ 1 untouched benchmark

Copy link
Collaborator Author

Secrus commented Jan 30, 2026

@mgorny since this changes how things work for Gentoo, could you check/confirm that /etc/localtime works on Gentoo?

PS if you know any other distro maintainers, please notify/ping them, I would love to get broader info on this matter

Copy link
Contributor

mgorny commented Jan 30, 2026

@mgorny since this changes how things work for Gentoo, could you check/confirm that /etc/localtime works on Gentoo?

If you're asking whether tests pass after this change on my system, they do. They also pass if I remove /etc/localtime altogether or copy the specific timezone there. I think that's all the scenarios we "support".

PS if you know any other distro maintainers, please notify/ping them, I would love to get broader info on this matter

CC @hroncok (sorry, don't recall anyone else offhand, though I really should have)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashb ashb Awaiting requested review from ashb

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

AltStyle によって変換されたページ (->オリジナル) /