-
-
Notifications
You must be signed in to change notification settings - Fork 417
Comments
Refactor: Optimize usage of re.* methods#741
Merged
Secrus merged 1 commit intopython-pendulum:master from Apr 24, 2025
Merged
Conversation
CodSpeed Performance Report
Merging #741 will not alter performance
Comparing eumiro:re-fullmatch (01b3968) with master (91d0c1e)
Summary
✅ 1 untouched benchmarks
@eumiro
eumiro
force-pushed
the
re-fullmatch
branch
5 times, most recently
from
August 19, 2023 19:58
e45b0db to
14459f8
Compare
@eumiro
eumiro
changed the title
(削除) Use re.fullmatch to match whole strings (削除ここまで)
(追記) Refactor: Optimize usage of re.* methods (追記ここまで)
Aug 19, 2023
@eumiro
eumiro
force-pushed
the
re-fullmatch
branch
from
March 2, 2025 14:34
14459f8 to
661b5e9
Compare
Collaborator
Secrus
commented
Apr 23, 2025
Hi. Sorry for the delays, we are digging ourselves out of the pile of code debt. Could you please rebase your changes with the master branch so we can review and merge them?
@eumiro
eumiro
force-pushed
the
re-fullmatch
branch
from
April 23, 2025 15:39
661b5e9 to
6588871
Compare
@eumiro
eumiro
force-pushed
the
re-fullmatch
branch
from
April 23, 2025 15:46
6588871 to
01b3968
Compare
Secrus
Secrus
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.