-
-
Notifications
You must be signed in to change notification settings - Fork 417
Comments
fix: pendulum.parse is not marked as exported#693
Merged
Secrus merged 1 commit intopython-pendulum:master from Apr 24, 2025
cosmix:master
Merged
fix: pendulum.parse is not marked as exported #693Secrus merged 1 commit intopython-pendulum:master from cosmix:master
pendulum.parse is not marked as exported #693Secrus merged 1 commit intopython-pendulum:master from
cosmix:master
Conversation
Contributor
Author
cosmix
commented
Mar 1, 2023
Note that the failing CI test has to do with the fact that the flake8 module that you're using seems to not like the import aliasing that needs to be used to fix the issue addressed by this PR and that exports the parse symbol in __init__.py.
For reference, I'm using the type checker rules listed on the pyright README here, but, to my understanding these are rules common to more type checkers for Python.
navmed
navmed
approved these changes
May 10, 2023
Secrus
Secrus
approved these changes
Mar 30, 2025
Collaborator
Secrus
commented
Apr 23, 2025
Hi. Sorry for the delays, we are digging ourselves out of the pile of code debt. Could you please rebase your changes with the master branch so we can review and merge them?
@Secrus
Secrus
changed the title
(削除) fixup: Fix #595 (削除ここまで)
(追記) fix: Apr 23, 2025
pendulum.parse is not marked as exported (追記ここまで)
Contributor
Author
cosmix
commented
Apr 23, 2025
@Secrus done.
CodSpeed Performance Report
Merging #693 will not alter performance
Comparing cosmix:master (7ef1b0b) with master (91d0c1e)
Summary
✅ 1 untouched benchmarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #595, by re-exporting
parse().parse()should be re-exported so that the user can just callpendulum.parse()as documented, given that the module is marked withpy.typed.No tests have been modified or added for this bugfix.