-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feature: Add support for .dotx Word templates (#1532) #1537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coderamaster
wants to merge
1
commit into
python-openxml:master
from
coderamaster:fix/1532-dotx-template-support
Open
Feature: Add support for .dotx Word templates (#1532) #1537
coderamaster
wants to merge
1
commit into
python-openxml:master
from
coderamaster:fix/1532-dotx-template-support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added WML_TEMPLATE_MAIN content type constant - Updated Document() to accept both .docx and .dotx files - Added part factory mapping for template content type - Added tests for .dotx template loading - Fixes python-openxml#1532
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1532.
Adds support for loading Word template files (
.dotx) withpython-docx.Document().Problem
Loading a
.dotxfile currently raises aValueErrordue to an unsupported content type. Even if bypassed, the part factory creates a genericPartinstead ofDocumentPart, causing anAttributeError.Solution
Treat
.dotxtemplates the same as.docxdocuments, which matches the OOXML spec.Changes:
DocumentPart.dotxloadingTesting
.dotxfiles.docxbehavior remains unchanged