Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add class IntelHexWord for word address#33

Open
benfre wants to merge 3 commits into
python-intelhex:master from
benfre:master
Open

add class IntelHexWord for word address #33
benfre wants to merge 3 commits into
python-intelhex:master from
benfre:master

Conversation

@benfre

@benfre benfre commented Jun 28, 2019

Copy link
Copy Markdown

for issue: #32

bialix commented Sep 27, 2019

Copy link
Copy Markdown
Member

Sorry for not working on your pull request. I'm looking for a new maintainer for Python IntelHex project. I hope someone will help.

bialix commented Jul 9, 2020
edited
Loading

Copy link
Copy Markdown
Member

I understand your intents, but it seems such format is not follow IntelHex-8 standard. Do you have any links or pdf document with hex word format explanations?
Anyway, I don't like the fact you changed the most time-critical function (decode_record). I think it's better to copy decode_record method entirely into new class and make modifications there. Also the IntelHex project is relying on unit tests. We need some unit tests for your class with some simple example of such word file.
Please, rework your class, add unit tests and write some text for manual.

Sorry for not reviewing your patch a year ago. If you don't need it anymore - please say so.

benfre commented Jul 11, 2020
edited
Loading

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /