Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix parsing limits #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anton-ryzhov wants to merge 2 commits into python-hyper:master
base: master
Choose a base branch
Loading
from anton-ryzhov:fix-parsing-limits

Conversation

@anton-ryzhov
Copy link

@anton-ryzhov anton-ryzhov commented Jul 5, 2025
edited
Loading

Fixes #182

maybe_read_from_IDLE_client and maybe_read_from_SEND_RESPONSE_server readers wait for concrete terminators and produce NEED_DATA events until that. After NEED_DATA max_incomplete_event_size limit is checked.

Here I'm adding consistent size limits for these events, that do not depend on chunking patterns.

To ensure that we need to reject complete request data chunk if incomplete request[:-1] already exceeds max_incomplete_event_size limit.

Practically max_complete_event_size = max_incomplete_event_size + 1 and enforced for "all or nothing" event readers.

I've added failing test with the first commit and the fix in the second.

Copy link
Author

@njsmith could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent parsing behavior

1 participant

AltStyle によって変換されたページ (->オリジナル) /