Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

CloudWatch custom dimensions and boto3 #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jantman wants to merge 5 commits into python-diamond:master
base: master
Choose a base branch
Loading
from jantman:cw-custom-dimension

Conversation

@jantman
Copy link

@jantman jantman commented Oct 6, 2017

This rolls up two improvements for the cloudwatch handler:

  1. Fix CloudWatch handler uses deprecated SDK #678 , switch from the deprecated boto AWS library (which, in addition to being deprecated, also doesn't support retrieving AWS credentials from the Instance Metadata Service or ECS Task Metadata).
  2. Add support for custom dimensions to send along with metrics, per-metric.

troyready reacted with thumbs up emoji
Copy link

coveralls commented Oct 6, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 24.649% when pulling 4d99403 on jantman:cw-custom-dimension into f2bece4 on python-diamond:master.

Copy link
Member

#707 added custom dimension support. Can you rebase this to get the boto3 switch done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CloudWatch handler uses deprecated SDK

AltStyle によって変換されたページ (->オリジナル) /