-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
803565d to
617be02
Compare
617be02 to
9dd4384
Compare
killpanda
commented
Sep 15, 2015
This PR is done.
firefly/models/like.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里等价于 return str(self._instance) 应该不是你预期的结果吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mozillazg 不是呀 这里是要通过 productidgetter 来拿到 product_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@killpanda 其实我也没看懂. 在productidgetter 里面 直接返回了参数 不就是 @mozillazg 说的意思么
其次 productidgetter这个方法名字 不是应该用下划线分词的么 比如 product_id_getter
dongweiming
commented
Sep 15, 2015
@killpanda 辛苦
firefly/views/api/topic.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete 应该也是204
killpanda
commented
Sep 26, 2015
大家看看现在怎么样?
halfcrazy
commented
Sep 27, 2015
@killpanda 现在清楚了不少。有一点,likes这个类,我觉得除了add delete方法要操作数据库,是不是还可以在内部维护一个list/set便于直接取用户
killpanda
commented
Sep 27, 2015
@halfcrazy 可以举个例子来说说用法吗?
halfcrazy
commented
Sep 28, 2015
@killpanda 知乎问题右边的,xxx,xxx关注了本问题
killpanda
commented
Oct 1, 2015
@halfcrazy 加了个 __getitem__,其它功能随用随加吧 XD
halfcrazy
commented
Oct 1, 2015
👍
Likesmodel